Conversation
|
Hey Frank, I'm happy to run test code with you to get these fields working on a US3000. I'm assuming this PR goes some way to fixing this issue, or perhaps they're not related? |
|
@Frankkkkk Hey, do you have any thoughts on getting the API to be happy with US3000 values? Do you think it'd need an API change? Perhaps through versioned calls or would you think overriding the fields would be more straightforward? I'd like to work on getting US3000 capacity up and running for our unit. :) |
|
Have you considered using construct.If to override the API's field StateOfCharge with US3000 values, if they exist? Much like you do in this PR with UserDefinedItems > 2? If not, I'll create a PR if I can do it cleanly. |
|
Hi @hrford If you have an MR for improving mine I'd happily take it :-) |
|
@Frankkkkk I've not forgotten this, life is in the way and I've not installed any remote equipment at the club yet. I have some code which I used keeping in the fashion that you've been doing, I didn't change the API naming to achieve it either :) So will get a PR in when I can. |
Still not merging because I'm not really happy with the construct structure: it would be way better to override the field with the US3000 values so that the API doesn't change...